Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added empty_circle plot aesthetic #174

Merged
merged 23 commits into from
Sep 23, 2024
Merged

Added empty_circle plot aesthetic #174

merged 23 commits into from
Sep 23, 2024
+4,894 −2,923

Conversation

sunroofgod
Copy link
Collaborator

@sunroofgod sunroofgod commented Mar 17, 2024 •
edited
Loading

NEW Features:

  • Added new DABEST feature for plotting of empty dots related swarmplots via empty_circle in .plot() method
  • Updated swarmplot function with two new features
    • dots can now be filled in accordance to filled parameter
    • swarmplots now come with automated generation of legends
  • Altman-Gardner two group plots now have summary lines leading up to CIs for swarmside="right".

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sunroofgod and others added 9 commits March 19, 2024 15:48
@sunroofgod
Resolve merge conflicts wrt asymmetric swarmplots and vnbdev branch
c71a4ee
@sunroofgod
Fixed bug involving empty_circle filled dots feature not working as i…
319f513 
…ntended
@Jacobluke-
Merge pull request #176 from ACCLAB/v2024.03.29
8e63177 
Merge v2024.03.29 into master branch
@Jacobluke-
Merge pull request #177 from ACCLAB/v2024.03.29
085a006 
Merge v2024.03.29 into master branch
@Jacobluke-
Merge pull request #178 from ACCLAB/v2024.03.29
97585d1 
Update on documentations
@sunroofgod
Updated swarmplot to produce legends if plotting by hue column
ff3a06f
@sunroofgod
Updated errorbar handling of xspans to properly account for when hue …
9f33da3 
…column is being used to plot for color_col is not None
@sunroofgod
Updated errorbar handling of xspans to properly account for when hue …
8edb941 
…column is being used to plot for color_col is not None
@sunroofgod
Updated swarmplot to produce legends if plotting by hue column
4b928b7
Jacobluke-
Jacobluke- reviewed Mar 25, 2024
View reviewed changes
dabest/plotter.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code is related to bug fixes of issue #108. Currently investigating

Jacobluke-
Jacobluke- requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@Jacobluke- Jacobluke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have to also try running the tut notebooks to generate the new plots.

@Jacobluke- Jacobluke- mentioned this pull request Jun 20, 2024
Closed
Jacobluke-
Jacobluke- approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Jacobluke- Jacobluke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set, forest plot related test images will be updated in next PR

@Jacobluke- Jacobluke- merged commit d047528 into vnbdev Sep 23, 2024
4 checks passed
@Jacobluke- Jacobluke- deleted the feat-asymmetric-swarmplots branch September 23, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacobluke- Jacobluke- Jacobluke- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunroofgod @Jacobluke-